K2 plugin migration #321
Open
K2 plugin migration #321
+355
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
reviewed
Oct 7, 2024
build.gradle.kts
Outdated
Comment on lines
97
to
119
| //tasks.named<RunIdeTask>("runIde") { | ||
| // jvmArgumentProviders += CommandLineArgumentProvider { | ||
| // listOf("-Didea.kotlin.plugin.use.k2=true") | ||
| // } | ||
| //} | ||
|
|
||
| //tasks.test { | ||
| // jvmArgumentProviders += CommandLineArgumentProvider { | ||
| // listOf("-Didea.kotlin.plugin.use.k2=true") | ||
| // } | ||
| //} | ||
|
|
There was a problem hiding this comment.
I believe we should not commit out-commented code.
There was a problem hiding this comment.
Without vm options, tests and debug IDE would be run against K1 mode. It's ok for 242 and below but for the 243+, it should be changed to something else. It's better to separate migration of the plugin and migration of the test infra indeed. Hopefully, it would be easy for the maintainers to find corresponding options without the comments.
| @@ -21,51 +21,6 @@ class SpecTests : LightJavaCodeInsightFixtureTestCase() { | |||
| return false | |||
| } | |||
|
|
|||
| fun testIsContainedInSpecFunSpec() { | |||
There was a problem hiding this comment.
Instead of merging `master´, rebase to keep the PR's history clean of merge commits for more convenient review.
- starting from 242, the plugin works over AnalysisAPI which hides all details about kotlin engine used inside kotlin plugin itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evident usages of K1 api (resolve) are migrated